Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756618AbcJNTlp (ORCPT ); Fri, 14 Oct 2016 15:41:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49852 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709AbcJNTll (ORCPT ); Fri, 14 Oct 2016 15:41:41 -0400 Subject: Re: [Xen-devel] [PATCH 6/8] xen/pvh: Initialize grant table for PVH guests To: Konrad Rzeszutek Wilk References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com> <1476468318-24422-7-git-send-email-boris.ostrovsky@oracle.com> <20161014191923.GD16777@localhost.localdomain> Cc: david.vrabel@citrix.com, JGross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com From: Boris Ostrovsky Message-ID: Date: Fri, 14 Oct 2016 15:43:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161014191923.GD16777@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 55 On 10/14/2016 03:19 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Oct 14, 2016 at 02:05:16PM -0400, Boris Ostrovsky wrote: > > Perhaps add in here: > > PVH is like PV in that there are no PCI devices - which HVM > code would piggyback on to find the Xen PCI platform device and > use its MMIO space to stash the grants in. > > For PVH we balloon out memory and stash the grants in there. > > (Which begs the next question - where and when do we balloon out the > normal memory back in?) Are you saying that we should get back memory that we gave to grant tables? -boris > >> Signed-off-by: Boris Ostrovsky >> --- >> drivers/xen/grant-table.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c >> index bb36b1e..d6786b8 100644 >> --- a/drivers/xen/grant-table.c >> +++ b/drivers/xen/grant-table.c >> @@ -1146,13 +1146,13 @@ int gnttab_init(void) >> >> static int __gnttab_init(void) >> { >> + if (!xen_domain()) >> + return -ENODEV; >> + >> /* Delay grant-table initialization in the PV on HVM case */ >> - if (xen_hvm_domain()) >> + if (xen_hvm_domain() && !xen_pvh_domain()) >> return 0; >> >> - if (!xen_pv_domain()) >> - return -ENODEV; >> - >> return gnttab_init(); >> } >> /* Starts after core_initcall so that xen_pvh_gnttab_setup can be called >> -- >> 1.8.3.1 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel