Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754862AbcJPIY1 (ORCPT ); Sun, 16 Oct 2016 04:24:27 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35782 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbcJPIYS (ORCPT ); Sun, 16 Oct 2016 04:24:18 -0400 Date: Sun, 16 Oct 2016 10:24:14 +0200 From: Alexander Alemayhu To: Sergio Paracuellos Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Replace data type declarations with variables of same types in several source files. Message-ID: <20161016082414.GA2077@gmail.com> References: <1476108142-27623-1-git-send-email-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476108142-27623-1-git-send-email-sergio.paracuellos@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 401 Lines: 13 On Mon, Oct 10, 2016 at 04:02:17PM +0200, Sergio Paracuellos wrote: > This patch series replaces several sizeof(struct XXX) stuff in favour > of sizeof(var) which is the preferred one. > Why not squash this series into one patch? The commit messages are fairly similar and the changes are focused into one area. Would be better with one commit, IMO. -- Mit freundlichen Gr??en Alexander Alemayhu