Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756844AbcJPPvA (ORCPT ); Sun, 16 Oct 2016 11:51:00 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59058 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753874AbcJPPu6 (ORCPT ); Sun, 16 Oct 2016 11:50:58 -0400 Subject: Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode To: Sylvain Rochet , Alexandre Belloni , Boris BREZILLON , linux-kernel@vger.kernel.org, Nicolas Ferre , Ludovic Desroches , linux-arm-kernel@lists.infradead.org References: <1444163325-3041-1-git-send-email-sylvain.rochet@finsecur.com> <20151007110112.GD3485@piout.net> <20161016153316.rsrcgnki6kn7gola@finsecur.com> Cc: stable@vger.kernel.org From: Guenter Roeck Message-ID: <67fe262e-31e4-b9dc-da71-af601079bfec@roeck-us.net> Date: Sun, 16 Oct 2016 08:50:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161016153316.rsrcgnki6kn7gola@finsecur.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 34 On 10/16/2016 08:33 AM, Sylvain Rochet wrote: > Hi, > > On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote: >> On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote : >>> Since turning on idle-halt in commit 5161b31dc39a (watchdog: >>> at91sam9_wdt: better watchdog support"), SoCs compatible with >>> at91sam9260-wdt not using a device tree no longer reboot if the watchdog >>> times out while the CPU is in idle state. Removing the >>> AT91_WDT_WDIDLEHLT flag that was set by default fixes this. >>> >>> Signed-off-by: Sylvain Rochet >>> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support") >>> Cc: # 3.14+ >> >> Acked-by: Alexandre Belloni >> >> However, we don't really care about that for kernels after 3.18 as no >> users are using pdata anymore. >> I think you could send a follow-up patch removing pdata support >> completely. > > Looks like this one falls through the cracks, it didn't reach mainline > and therefore wasn't applied to stable branches. > Possibly that happened because you did not copy the watchdog mailing list. Guenter > I just checked, it still apply properly on today's linux-next branch. > > Cheers, > Sylvain >