Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756008AbcJPQT5 (ORCPT ); Sun, 16 Oct 2016 12:19:57 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33393 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754307AbcJPQTu (ORCPT ); Sun, 16 Oct 2016 12:19:50 -0400 Date: Sun, 16 Oct 2016 18:19:45 +0200 From: Ingo Molnar To: Masahiro Yamada Cc: Andrew Morton , linux-arch@vger.kernel.org, Peter Oberparleiter , Arnd Bergmann , Kees Cook , Michal Marek , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Thomas Garnier Subject: Re: [PATCH] kconfig.h: remove config_enabled() macro Message-ID: <20161016161945.GA1456@gmail.com> References: <1476616078-32252-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476616078-32252-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 24 * Masahiro Yamada wrote: > The use of config_enabled() is ambiguous. For config options, > IS_ENABLED(), IS_REACHABLE(), etc. will make intention clearer. > Sometimes config_enabled() has been used for non-config options > because it is useful to check whether the given symbol is defined > or not. > > I have been tackling on deprecating config_enabled(), and now is the > time to finish this work. > > Some new users have appeared for v4.9-rc1, but it is trivial to > replace them: > > - arch/x86/mm/kaslr.c > replace config_enabled() with IS_ENABLED() because > CONFIG_X86_ESPFIX64 and CONFIG_EFI are boolean. Acked-by: Ingo Molnar Thanks, Ingo