Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932509AbcJPQ6a (ORCPT ); Sun, 16 Oct 2016 12:58:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:47268 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757113AbcJPQ61 (ORCPT ); Sun, 16 Oct 2016 12:58:27 -0400 Subject: Re: [PATCH] MD-RAID: Use seq_putc() in three status functions To: SF Markus Elfring , linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Joe Perches , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <92c52f1d-d151-cea6-e9ac-31378e6862d0@users.sourceforge.net> <1475771699.1914.10.camel@perches.com> <77fb6fdc-7480-8607-0af1-42f73c125b9d@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: Hannes Reinecke Message-ID: <688764a4-072d-2faf-37ba-a222b190a5d9@suse.de> Date: Sun, 16 Oct 2016 18:58:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <77fb6fdc-7480-8607-0af1-42f73c125b9d@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 68 On 10/16/2016 10:20 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 16 Oct 2016 10:10:28 +0200 > > A single character (a closing square bracket) should be put into a sequence > at the end in these functions. > Thus use the corresponding function "seq_putc". > > This issue was detected also by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/md/raid1.c | 2 +- > drivers/md/raid10.c | 2 +- > drivers/md/raid5.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c > index 1961d82..fd97f65 100644 > --- a/drivers/md/raid1.c > +++ b/drivers/md/raid1.c > @@ -1418,7 +1418,7 @@ static void raid1_status(struct seq_file *seq, struct mddev *mddev) > rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > } > rcu_read_unlock(); > - seq_printf(seq, "]"); > + seq_putc(seq, ']'); > } > > static void raid1_error(struct mddev *mddev, struct md_rdev *rdev) > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c > index be1a9fc..7490b28 100644 > --- a/drivers/md/raid10.c > +++ b/drivers/md/raid10.c > @@ -1499,7 +1499,7 @@ static void raid10_status(struct seq_file *seq, struct mddev *mddev) > seq_printf(seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > } > rcu_read_unlock(); > - seq_printf(seq, "]"); > + seq_putc(seq, ']'); > } > > /* check if there are enough drives for > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 92ac251..9eb45c4 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -7077,7 +7077,7 @@ static void raid5_status(struct seq_file *seq, struct mddev *mddev) > seq_printf (seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > } > rcu_read_unlock(); > - seq_printf (seq, "]"); > + seq_putc(seq, ']'); > } > > static void print_raid5_conf (struct r5conf *conf) > The point of this patch being ... what? Does it improve code? Does it improve anything? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)