Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757057AbcJPRMF (ORCPT ); Sun, 16 Oct 2016 13:12:05 -0400 Received: from mx-guillaumet.finsecur.com ([91.217.234.131]:41814 "EHLO guillaumet.finsecur.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757345AbcJPRL6 (ORCPT ); Sun, 16 Oct 2016 13:11:58 -0400 Date: Sun, 16 Oct 2016 18:43:26 +0200 From: Sylvain Rochet To: Peter Rosin Cc: Alexandre Belloni , linux-arm-kernel@lists.infradead.org, Peter Rosin , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20161016164326.ep4gjpbeubyfgsjq@finsecur.com> References: <1443105855-15738-1-git-send-email-peda@lysator.liu.se> <20150924144753.GY4287@piout.net> <6d2d5aba-cca3-93c6-0c59-3acbbd7b6169@lysator.liu.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d2d5aba-cca3-93c6-0c59-3acbbd7b6169@lysator.liu.se> User-Agent: NeoMutt/20160916 (1.7.0) X-SA-Exim-Connect-IP: 172.16.8.13 X-SA-Exim-Mail-From: sylvain.rochet@finsecur.com Subject: Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on guillaumet.finsecur.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 21 Hi Peter, On Sun, Oct 16, 2016 at 12:57:09PM +0200, Peter Rosin wrote: > Hi again, > > I forgot about this, and it's been a year. But isn't it time to > upstream those pull-up fixes that Sylvain provided? Thank you for your reminder, actually I waited an answer on this nice subject: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368643.html But this is not relevant for this change anyway, if we should set a pull-(up|down) on all push-pull pads to reduce power consumption it should be enforced in the pinctrl driver, the dt must stay logical. I just sent a v2 with all useless comments removed as suggested by Alexandre and without the explanation about the removed extra power consumption when removing a pull-(up|down) on a push-pull output because it does even seem to be the contrary on Atmel SoCs. Sylvain