Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757293AbcJPSnf (ORCPT ); Sun, 16 Oct 2016 14:43:35 -0400 Received: from terminus.zytor.com ([198.137.202.10]:36556 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbcJPSn1 (ORCPT ); Sun, 16 Oct 2016 14:43:27 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20161016163557.weyfwd4obnk3rh5v@pd.tnic> References: <20161012175731.29619-1-piotr.luc@intel.com> <20161016142233.xuqrahty6gcwq7en@pd.tnic> <20161016163557.weyfwd4obnk3rh5v@pd.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [tip:x86/urgent] x86/cpufeature: Add AVX512_4VNNIW and AVX512_4FMAPS features From: hpa@zytor.com Date: Sun, 16 Oct 2016 11:42:26 -0700 To: Borislav Petkov CC: Ingo Molnar , peterz@infradead.org, tglx@linutronix.de, dave.hansen@intel.com, torvalds@linux-foundation.org, piotr.luc@intel.com, luto@kernel.org, brgerst@gmail.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, jpoimboe@redhat.com, linux-tip-commits@vger.kernel.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 17 On October 16, 2016 9:35:57 AM PDT, Borislav Petkov wrote: >On Sun, Oct 16, 2016 at 09:02:51AM -0700, hpa@zytor.com wrote: >> No, please. That would be worse than the disease. > >Why not? > >I did that recently with a bunch of leaves and there were no issues: > >2ccd71f1b278 ("x86/cpufeature: Move some of the scattered feature bits >to x86_capability") > >There it obviously made sense for 0x00000006 and 0x8000000a to have a >separate ->x86_capability leaf. It's needlessly adding complexity for no reason, at least for the leaves that are going to add bits over time. The x86_capability array is not an expensive resource. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.