Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757145AbcJQF5Z (ORCPT ); Mon, 17 Oct 2016 01:57:25 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:52179 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756495AbcJQF5Q (ORCPT ); Mon, 17 Oct 2016 01:57:16 -0400 Subject: Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller To: Sekhar Nori , Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , Karl Beldan References: <1475672732-17111-1-git-send-email-bgolaszewski@baylibre.com> <1475672732-17111-3-git-send-email-bgolaszewski@baylibre.com> <2d276e51-9d37-8648-4aad-283bb2b23626@ti.com> CC: LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , David Airlie , Laurent Pinchart , Maxime Ripard , Karl Beldan From: Tomi Valkeinen Message-ID: <1e23c3e9-d34b-1d8f-8565-c9932a60fd32@ti.com> Date: Mon, 17 Oct 2016 08:56:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <2d276e51-9d37-8648-4aad-283bb2b23626@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r5xkqjl6GgfEiPEQko1vgGrPfBciXsM4A" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3290 Lines: 85 --r5xkqjl6GgfEiPEQko1vgGrPfBciXsM4A Content-Type: multipart/mixed; boundary="1UvQnqg5gNLv4C6hk3CkR9dDeWDefE9HH"; protected-headers="v1" From: Tomi Valkeinen To: Sekhar Nori , Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , Karl Beldan Cc: LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , David Airlie , Laurent Pinchart , Maxime Ripard , Karl Beldan Message-ID: <1e23c3e9-d34b-1d8f-8565-c9932a60fd32@ti.com> Subject: Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller References: <1475672732-17111-1-git-send-email-bgolaszewski@baylibre.com> <1475672732-17111-3-git-send-email-bgolaszewski@baylibre.com> <2d276e51-9d37-8648-4aad-283bb2b23626@ti.com> In-Reply-To: <2d276e51-9d37-8648-4aad-283bb2b23626@ti.com> --1UvQnqg5gNLv4C6hk3CkR9dDeWDefE9HH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15/10/16 20:42, Sekhar Nori wrote: >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dt= si >> index f79e1b9..32908ae 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >=20 >> @@ -399,6 +420,14 @@ >> <&edma0 0 1>; >> dma-names =3D "tx", "rx"; >> }; >> + >> + display: display@213000 { >> + compatible =3D "ti,am33xx-tilcdc", "ti,da850-tilcdc"; >=20 > This should instead be: >=20 > compatible =3D "ti,da850-tilcdc", "ti,am33xx-tilcdc"; >=20 > as the closest match should appear first in the list. Actually I don't think that's correct. The LCDC on da850 is not compatible with the LCDC on AM335x. I think it should be just "ti,da850-tilcdc". Tomi --1UvQnqg5gNLv4C6hk3CkR9dDeWDefE9HH-- --r5xkqjl6GgfEiPEQko1vgGrPfBciXsM4A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYBGgAAAoJEPo9qoy8lh71XTAP/Av1WgGRk9oEsEGN3KCYHALp 2AxBwfwD/2mZsyYJCdH6Gklxb+vYOE+ePMkCEi6SMj1NKox8OJtAZxQR1cHxSqjP Mlu3ABifQHQsw/kiYl5Tz+OJbJOSRj3wUYeIEtqzotCktrqatWeRi5vWvnEkfZCV t4yuyT7EW122qhrSW1tDSN9drQvjtJoqobbqEVfgZXoc1fMiIjRA8NbILHSqT+A9 d5vpmkgfwBJgvEywuuGk7FkKR7hpX89YUDFm1KBmBonxd+TDiYjiFjSTMclmfm0x KP+8V7wEzxyZAZRWTwzbXWXucZok7ymqV6h1RVs7iDGI65AGDvX4OUp9a1zu9+LK m/50LmDo7g5bpTpn5tqNxbnXvF0WQujTI+Rh/+8rIq6cyJyoezPCpk26TX0DTpPB aTtf/rbmDf5NCA54PqP4Em/ORu89ut91ENqrYBqm+iBxOdo+hGHlfh/V/OAVbrtJ hOWcupUbaB+h5cjcZEm5QzUhHuP0dt93KnEMqmQABcJOA+b2qhgaJpu6NE2xZaFg IbB3fA3L/wpE10uFTt6pUV9jCBUv0shZ0tp/Kobvx7L6DyriXPreaonLsg+8zH04 zGjYUBKNpyKT99Jf5HevsfDrNkJJwCZOBlailIq2TWZsrpYIL9PiI3+wu+GLlerT VFD9ewvYgGbZxZLAagWI =FR00 -----END PGP SIGNATURE----- --r5xkqjl6GgfEiPEQko1vgGrPfBciXsM4A--