Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757496AbcJQF67 (ORCPT ); Mon, 17 Oct 2016 01:58:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:41648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbcJQF64 (ORCPT ); Mon, 17 Oct 2016 01:58:56 -0400 Subject: Re: MD-RAID: Use seq_putc() in three status functions? To: SF Markus Elfring References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <92c52f1d-d151-cea6-e9ac-31378e6862d0@users.sourceforge.net> <1475771699.1914.10.camel@perches.com> <77fb6fdc-7480-8607-0af1-42f73c125b9d@users.sourceforge.net> <688764a4-072d-2faf-37ba-a222b190a5d9@suse.de> <59d71170-c48d-a084-c748-b6ab74a2bee4@users.sourceforge.net> Cc: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Joe Perches , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , kernel-janitors@vger.kernel.org From: Hannes Reinecke Message-ID: <1e151094-e228-5307-ae2f-b376b31f5628@suse.de> Date: Mon, 17 Oct 2016 07:58:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <59d71170-c48d-a084-c748-b6ab74a2bee4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 25 On 10/16/2016 07:10 PM, SF Markus Elfring wrote: >> Does it improve code? Does it improve anything? > > Yes. - I got such an impression. > > * Is it more efficient to call the function "seq_printf" for the desired data processing > for a single character than to pass it to the function "" in a string? > > * Will the required data transfer shrink a bit for the affected functions because of > such a change? > Which are questions _you_ should be able to answer. It's your patch, after all. Once you do (and prove that the answer is 'yes' to the above two questions) the patch will be applied. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)