Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757501AbcJQG7R (ORCPT ); Mon, 17 Oct 2016 02:59:17 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:60425 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756265AbcJQG7J (ORCPT ); Mon, 17 Oct 2016 02:59:09 -0400 From: Lipengcheng To: Peter Chen , "balbi@kernel.org" CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: USB GADGET: have a question about usb2eth Thread-Topic: USB GADGET: have a question about usb2eth Thread-Index: AdImxTynS1Vo/LA8Rz6fw2nkJznvUwBEVu0AABrpsnA= Date: Mon, 17 Oct 2016 06:50:14 +0000 Message-ID: <637796ED17F7774FB27D6AAE3C6951584A949CBB@SZXEMA509-MBS.china.huawei.com> References: <637796ED17F7774FB27D6AAE3C6951584A949A31@SZXEMA509-MBS.china.huawei.com> <20161017015618.GB1301@b29397-desktop> In-Reply-To: <20161017015618.GB1301@b29397-desktop> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.223.197] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9H6xLNj032029 Content-Length: 1768 Lines: 39 Hi, thank you for your suggestion. I have a question about usb2eth. In the function gen_ndis_set_resp of the rndis.c, the value of *params->filter may be 0x20 from the pc set command; Howerver the value is used cdc_filter = dev->port_usb->cdc_filter in the function eth_start_xmit of the u_ether.c. If we do not judge the RNDIS_PACKET_TYPE_PROMISCUOUS and the value is 0x20, the broadcast packet can not send the pc win7; At the result, the linux ping the win7 is slow an the first. At the same time, Why are different value between RNDIS_PACKET_TYPE_PROMISCUOUS and USB_CDC_PACKET_TYPE_PROMISCUOUS? If the value of RNDIS_PACKET_TYPE_PROMISCUOUS and USB_CDC_PACKET_TYPE_PROMISCUOUS is same, then the linux ping the win7 is normal speed. Best Regards Pengcheng Li > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Monday, October 17, 2016 9:56 AM > To: Lipengcheng > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: USB GADGET: have a question about usb2eth > > On Sat, Oct 15, 2016 at 09:19:33AM +0000, Lipengcheng wrote: > > Hi, > > I have a question about usb2eth. In the function gen_ndis_set_resp of the rndis.c, the value of *params->filter may be 0x20 from the pc > set command; Howerver the value is used cdc_filter = dev->port_usb->cdc_filter in the function eth_start_xmit of the u_ether.c. If we do not > judge the RNDIS_PACKET_TYPE_PROMISCUOUS and the value is 0x20, the broadcast packet can not send the pc win7; At the result, the linux > ping the win7 is slow an the first. > > > > The Felipe's email has changed, please check MAINTAINERS. > Besides, would you wrap up line to 75 characters please? > > -- > > Best Regards, > Peter Chen