Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757572AbcJQHFS (ORCPT ); Mon, 17 Oct 2016 03:05:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37972 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756546AbcJQHFK (ORCPT ); Mon, 17 Oct 2016 03:05:10 -0400 Date: Mon, 17 Oct 2016 09:05:17 +0200 From: Greg KH To: Andy Lutomirski Cc: Andy Lutomirski , Herbert Xu , "linux-kernel@vger.kernel.org" , USB list Subject: Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space Message-ID: <20161017070517.GC25077@kroah.com> References: <7c12b3d10f457bc97e63be6c64acd87afb50aeea.1475774653.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 19 On Sun, Oct 16, 2016 at 10:17:53AM -0700, Andy Lutomirski wrote: > On Thu, Oct 6, 2016 at 10:25 AM, Andy Lutomirski wrote: > > Pointing an sg list at the stack is verboten and, with > > CONFIG_VMAP_STACK=y, will malfunction. Use kmalloc for the wusb > > crypto stack space instead. > > > > Untested -- I'm not entirely convinced that this hardware exists in > > the wild. > > Greg, could you queue this up for 4.9? I can't guarantee that it > works, but I can pretty much guarantee that the driver is busted > without it. Yes, it's in my queue, couldn't do anything until after -rc1 came out. I'll catch up on it this week. thanks, greg k-h