Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932976AbcJQHrD (ORCPT ); Mon, 17 Oct 2016 03:47:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38181 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860AbcJQHqi (ORCPT ); Mon, 17 Oct 2016 03:46:38 -0400 Date: Mon, 17 Oct 2016 09:46:44 +0200 From: Greg KH To: Pankaj Bharadiya Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: Replace CamelCase namings with underscores. Message-ID: <20161017074644.GB7010@kroah.com> References: <1476647035-23634-1-git-send-email-pankaj.bharadiya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476647035-23634-1-git-send-email-pankaj.bharadiya@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 43 On Mon, Oct 17, 2016 at 01:13:55AM +0530, Pankaj Bharadiya wrote: > Replace CamelCase names with underscores to comply with the standard > kernel coding style. > > Signed-off-by: Pankaj Bharadiya > --- > drivers/staging/dgnc/dgnc_tty.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > index ef9a45b..1a21902 100644 > --- a/drivers/staging/dgnc/dgnc_tty.c > +++ b/drivers/staging/dgnc/dgnc_tty.c > @@ -45,7 +45,7 @@ > /* > * internal variables > */ > -static unsigned char *dgnc_TmpWriteBuf; > +static unsigned char *dgnc_tmp_write_buf; Why not just fix the code to not have this variable at all? It's not correct to have it from what I can tell... Also, you modify many different variables all at once, can you please just modify one at a time (one per patch), to make it more obvious it is correct? > /* > * Default transparent print information. > @@ -69,7 +69,7 @@ > * This defines a raw port at 9600 baud, 8 data bits, no parity, > * 1 stop bit. > */ > -static struct ktermios DgncDefaultTermios = { > +static struct ktermios dgnc_default_termios = { rename to "default_termios"? No need to keep the driver name prefix on a static variable, right? thanks, greg k-h