Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932807AbcJQINB (ORCPT ); Mon, 17 Oct 2016 04:13:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:47089 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757728AbcJQHz0 (ORCPT ); Mon, 17 Oct 2016 03:55:26 -0400 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jeff Mahoney , Dave Chinner , Brian Foster , Jiri Slaby Subject: [PATCH 3.12 37/84] xfs: fixed signedness of error code in xfs_inode_buf_verify Date: Mon, 17 Oct 2016 09:51:24 +0200 Message-Id: X-Mailer: git-send-email 2.10.1 In-Reply-To: <2d291fde5f706ac081e8cfc0ebe7e31dd534dfe7.1476690493.git.jslaby@suse.cz> References: <2d291fde5f706ac081e8cfc0ebe7e31dd534dfe7.1476690493.git.jslaby@suse.cz> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 37 From: Jeff Mahoney 3.12-stable review patch. If anyone has any objections, please let me know. =============== Prior to v3.17, XFS used positive error codes internally. Commit af8d971602b9583e5e8400e637e2a48c7480bc64 (xfs: inode recovery readahead can race with inode buffer creation), upstream commit b79f4a1c68bb99152d0785ee4ea3ab4396cdacc6 backported from later releases need the error code signs reversed. Negative error codes will cause assertion failures (BUG_ON on kernels with assertions enabled. Signed-off-by: Jeff Mahoney Cc: Dave Chinner Cc: Brian Foster Signed-off-by: Jiri Slaby --- fs/xfs/xfs_inode_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_inode_buf.c b/fs/xfs/xfs_inode_buf.c index 4b1447b3a9e4..03d237a0f58b 100644 --- a/fs/xfs/xfs_inode_buf.c +++ b/fs/xfs/xfs_inode_buf.c @@ -99,7 +99,7 @@ xfs_inode_buf_verify( XFS_RANDOM_ITOBP_INOTOBP))) { if (readahead) { bp->b_flags &= ~XBF_DONE; - xfs_buf_ioerror(bp, -EIO); + xfs_buf_ioerror(bp, EIO); return; } -- 2.10.1