Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933599AbcJQJVM (ORCPT ); Mon, 17 Oct 2016 05:21:12 -0400 Received: from mail-yb0-f193.google.com ([209.85.213.193]:35840 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932949AbcJQJVF (ORCPT ); Mon, 17 Oct 2016 05:21:05 -0400 MIME-Version: 1.0 In-Reply-To: <1476695556-31966-1-git-send-email-pankaj.bharadiya@gmail.com> References: <1476695556-31966-1-git-send-email-pankaj.bharadiya@gmail.com> From: Viresh Kumar Date: Mon, 17 Oct 2016 14:51:03 +0530 X-Google-Sender-Auth: 4TJ9i-cvr95a2ND-ZKnlMJzVhmA Message-ID: Subject: Re: [PATCH] staging: greybus: audio: remove redundant slot field To: Pankaj Bharadiya Cc: Greg Kroah-Hartman , driver-dev , Alex Elder , Vaibhav Agarwal , mgreer@animalcreek.com, "linux-kernel@vger.kernel.org" , Johan Hovold Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 18 On Mon, Oct 17, 2016 at 2:42 PM, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's intf_id field maintains the > information about the interface on which module is connected hence > having an extra slot field is redundant. > > Thus remove the slot field and its associated code. > > Signed-off-by: Pankaj Bharadiya > --- > drivers/staging/greybus/audio_codec.h | 1 - > drivers/staging/greybus/audio_manager.h | 1 - > drivers/staging/greybus/audio_manager_module.c | 17 +---------------- > drivers/staging/greybus/audio_manager_sysfs.c | 7 +++---- > drivers/staging/greybus/audio_module.c | 1 - > 5 files changed, 4 insertions(+), 23 deletions(-) Acked-by: Viresh Kumar