Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758493AbcJQJkZ (ORCPT ); Mon, 17 Oct 2016 05:40:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:50732 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757189AbcJQJkY (ORCPT ); Mon, 17 Oct 2016 05:40:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="asc'?scan'208";a="890722322" From: Felipe Balbi To: Pengcheng Li , johnyoun@synopsys.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, xuejiancheng@hisilicon.com, lidongpo@hisilicon.com, caizhiyong@hisilicon.com, Pengcheng Li Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting In-Reply-To: <1474634096-106548-1-git-send-email-lpc.li@hisilicon.com> References: <1474634096-106548-1-git-send-email-lpc.li@hisilicon.com> Date: Mon, 17 Oct 2016 12:37:10 +0300 Message-ID: <87vawrs4e1.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 45 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Pengcheng Li writes: > The USBTRDTIM field needs to be cleared before setting a new value. > Otherwise it will result in an incorrect value if phyif =3D=3D GUSBCFG_PH= YIF8. > > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f > Signed-off-by: Pengcheng Li > Acked-by: John Youn which commit are you fixing? Seems like you're missing a: Fixes: foobar .... line here. Also, you need to remove Gerritisms from commit log ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYBJvGAAoJEMy+uJnhGpkGiaMQANs72BX4+p2FY4Tv/QvDZmmC qCFe4c2KDgPNi0KaK5wXFgJdjSmo/nUp2Pu6Gl9yRVXnFJSAoo5d3kfhTy5ElFnB Wkpr2KCM6yrVw9mOQ5w5cKqlZzaGeL2ikXllyFssDEaCLuYAAYtYmu5usP0UULkx 0qVdKM46luZt7cvEqVAvOvbhVvvkSRopF7yZsvttbVGE4jl4VGI1L6nnInnX88+s si9FolBZUMENTxVbIHgZYfExfONNSV2L10Vasp3LW8eSLg9ADuQN+QT3mMnLG5JK Ft7O3Vp6be2nZ+qINsO1jbbby4cAPlm7M/HalQ4xmTWRqwQjr1WvUEO7lg5oZKr/ SO7BHilF5Fq3bbEN0Z5ZRBtu3sTqqheh18CxTgToPsY5UHo2cvSPNOPfta4SJaJJ RpF6AXuDGK/ORubh9Fg7FqSB+BxRmOlG+YcE3odiDTmLEshq7j0YDOZynMAbb2qs Ac9T9p95XBrLSTsIu3corgnVJOimMzI18ZWreExCT4GfbtE6oqK/+dVItUiRdCXq CSBo691UQHWewZUNeWE0grurqEvPQQlNj+RyS+nkFHbavxVV3BKMtWvaWaVfKETO FONAVN7m6sA3BQSfw/8cPDFGxD8bqX94wBx2V5+jhp4CX3G/PUJ0VN7Dn/NDJTw/ Xqx2FOTtcxEPv8hVYXYs =Z0XH -----END PGP SIGNATURE----- --=-=-=--