Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932698AbcJQNfT (ORCPT ); Mon, 17 Oct 2016 09:35:19 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34507 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbcJQNfJ (ORCPT ); Mon, 17 Oct 2016 09:35:09 -0400 From: Shyam Saini To: gregkh@linuxfoundation.org Cc: bankarsandhya512@gmail.com, bmarsh94@gmail.com, eraretuya@gmail.com, aquannie@gmail.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Shyam Saini Subject: [PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444' Date: Mon, 17 Oct 2016 19:04:46 +0530 Message-Id: <1476711286-12560-1-git-send-email-mayhs11saini@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 24 Fixed following checkpatch warning WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Shyam Saini --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c index 8ed4d39..19b550f 100644 --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c @@ -38,7 +38,7 @@ static u8 bits_magic[] = { static struct platform_device *firmware_pdev; static char *file = "xlinx_fpga_firmware.bit"; -module_param(file, charp, S_IRUGO); +module_param(file, charp, 0444); MODULE_PARM_DESC(file, "Xilinx FPGA firmware file."); static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize) -- 2.7.4