Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757696AbcJQNjp (ORCPT ); Mon, 17 Oct 2016 09:39:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:43439 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757366AbcJQNjh (ORCPT ); Mon, 17 Oct 2016 09:39:37 -0400 Date: Mon, 17 Oct 2016 15:39:35 +0200 From: Johannes Thumshirn To: Arnd Bergmann Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , James Bottomley , Sebastian Herbszt , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lpfc: use %zd format string for size_t Message-ID: <20161017133934.wr5ukie7p5t7qvwa@linux-x5ow.site> References: <20161017123605.2217411-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161017123605.2217411-1-arnd@arndb.de> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1102 Lines: 24 On Mon, Oct 17, 2016 at 02:35:46PM +0200, Arnd Bergmann wrote: > A recent bugfix introduced a harmless warning in the lpfc driver: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_write_firmware': > drivers/scsi/lpfc/lpfc_logmsg.h:56:45: error: format '%ld' expects argument of type 'long int', but argument 9 has type 'size_t {aka const unsigned int}' [-Werror=format=] > > 'size_t' is always the same width as 'long' in the kernel, but the compiler > doesn't know that. The %z modifier is what the standard expects to be > used here, and this shuts up the warning. > > Fixes: 679053c651fb ("scsi: lpfc: Fix fw download on SLI-4 FC adapters") > Signed-off-by: Arnd Bergmann > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850