Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757953AbcJQOPg (ORCPT ); Mon, 17 Oct 2016 10:15:36 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:36120 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757789AbcJQOPZ (ORCPT ); Mon, 17 Oct 2016 10:15:25 -0400 MIME-Version: 1.0 In-Reply-To: <20161017135957.20297-2-ralf@ramses-pyramidenbau.de> References: <20161017135957.20297-1-ralf@ramses-pyramidenbau.de> <20161017135957.20297-2-ralf@ramses-pyramidenbau.de> From: Geert Uytterhoeven Date: Mon, 17 Oct 2016 16:15:24 +0200 X-Google-Sender-Auth: ybu_lTFgVugYtlA513ZEkzXLb84 Message-ID: Subject: Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation To: Ralf Ramsauer Cc: Mark Brown , Wolfram Sang , Linux SPI , Linux I2C , "linux-kernel @ vger . kernel . org" , Pantelis Antoniou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 30 On Mon, Oct 17, 2016 at 3:59 PM, Ralf Ramsauer wrote: > Instantiated SPI device nodes are marked with OF_POPULATE. This was > introduced in bd6c164. On unloading, loaded device nodes will of course > be unmarked. The problem are nodes that fail during initialisation: If a > node fails, it won't be unloaded and hence not be unmarked. > > If a SPI driver module is unloaded and reloaded, it will skip nodes that > failed before. > > Skip device nodes that are already populated and mark them only in case > of success. > > Note that the same issue exists for I2C. > > Fixes: bd6c164 ("spi: Mark instantiated device nodes with OF_POPULATE") > Signed-off-by: Ralf Ramsauer Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds