Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935084AbcJQOkm (ORCPT ); Mon, 17 Oct 2016 10:40:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51534 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932273AbcJQOkd (ORCPT ); Mon, 17 Oct 2016 10:40:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org DE11161157 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org References: <1476713146-26632-1-git-send-email-javier@osg.samsung.com> <1476713146-26632-5-git-send-email-javier@osg.samsung.com> From: Timur Tabi Message-ID: <5804E2DE.3010502@codeaurora.org> Date: Mon, 17 Oct 2016 09:40:30 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <1476713146-26632-5-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 27 Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/net/ethernet/qualcomm/emac/qcom-emac.ko | grep alias > alias: platform:qcom-emac > > After this patch: > > $ modinfo drivers/net/ethernet/qualcomm/emac/qcom-emac.ko | grep alias > alias: platform:qcom-emac > alias: of:N*T*Cqcom,fsm9900-emacC* > alias: of:N*T*Cqcom,fsm9900-emac > > Signed-off-by: Javier Martinez Canillas Acked-by: Timur Tabi -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.