Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964879AbcJQOoC (ORCPT ); Mon, 17 Oct 2016 10:44:02 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47484 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933005AbcJQOnx (ORCPT ); Mon, 17 Oct 2016 10:43:53 -0400 Subject: Re: [PATCH] perf annotate: Cleanup arch specific stuff To: Arnaldo Carvalho de Melo References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1476107942-9200-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161010162412.GK4809@kernel.org> <20161010163928.GA3816@naverao1-tp.localdomain> <57FBC698.6070303@linux.vnet.ibm.com> <20161010165616.GM4809@kernel.org> Cc: "Naveen N. Rao" , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, hekuang@huawei.com, jpoimboe@redhat.com, eranian@google.com, adrian.hunter@intel.com, mhiramat@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com, Ravi Bangoria From: Ravi Bangoria Date: Mon, 17 Oct 2016 20:13:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20161010165616.GM4809@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101714-0056-0000-0000-000001A784D6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005928; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000187; SDB=6.00769358; UDB=6.00368586; IPR=6.00545768; BA=6.00004812; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013016; XFM=3.00000011; UTC=2016-10-17 14:43:49 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101714-0057-0000-0000-000005DA8A3A Message-Id: <5804E39A.3080109@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610170257 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 36 On Monday 10 October 2016 10:26 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 10, 2016 at 10:19:28PM +0530, Ravi Bangoria escreveu: >> >> On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote: >>> On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote: >>>> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu: >>>>> Move arch specific stuff from util/annotate.c to their respective >>>>> files in util/annotate directory. >>>>> >>>>> No functionality changes. >>>>> >>>>> Signed-off-by: Ravi Bangoria >>>>> --- >>>>> tools/perf/util/Build | 1 + >>>>> tools/perf/util/annotate.c | 259 +++---------------------------------- >>>>> tools/perf/util/annotate.h | 23 ++++ >>>>> tools/perf/util/annotate/Build | 3 + >>>>> tools/perf/util/annotate/arm.c | 50 +++++++ >>>>> tools/perf/util/annotate/powerpc.c | 63 +++++++++ >>>>> tools/perf/util/annotate/x86.c | 107 +++++++++++++++ >>>> We already have a per arch area: tools/perf/arch/ >>> I think this was done to support cross-arch annotate similar to the >>> remote unwind support with util/libunwind/ >> Yes, because tools/perf/arch/ will only include host arch code. > Ok, thanks for clarifying. Hi Arnaldo, Are you ok with this patchset. Please let me know if you want to respin it. -Ravi > - Arnaldo >