Subject: Re: [PATCH] perf annotate: Cleanup arch specific stuff
To: Arnaldo Carvalho de Melo <acme@kernel.org>
References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
 <1476107942-9200-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>
 <20161010162412.GK4809@kernel.org>
 <20161010163928.GA3816@naverao1-tp.localdomain>
 <57FBC698.6070303@linux.vnet.ibm.com> <20161010165616.GM4809@kernel.org>
 <5804E39A.3080109@linux.vnet.ibm.com> <20161017144558.GP12815@kernel.org>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        hekuang@huawei.com, jpoimboe@redhat.com, eranian@google.com,
        adrian.hunter@intel.com, mhiramat@kernel.org, pawel.moll@arm.com,
        chris.ryder@arm.com, Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Date: Mon, 17 Oct 2016 20:19:32 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20161017144558.GP12815@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Message-Id: <5804E4FC.3000005@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1806
Lines: 40


On Monday 17 October 2016 08:15 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 17, 2016 at 08:13:38PM +0530, Ravi Bangoria escreveu:
>>
>> On Monday 10 October 2016 10:26 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Mon, Oct 10, 2016 at 10:19:28PM +0530, Ravi Bangoria escreveu:
>>>> On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote:
>>>>> On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote:
>>>>>> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu:
>>>>>>> Move arch specific stuff from util/annotate.c to their respective
>>>>>>> files in util/annotate directory.
>>>>>>>
>>>>>>> No functionality changes.
>>>>>>>
>>>>>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
>>>>>>> ---
>>>>>>>  tools/perf/util/Build              |   1 +
>>>>>>>  tools/perf/util/annotate.c         | 259 +++----------------------------------
>>>>>>>  tools/perf/util/annotate.h         |  23 ++++
>>>>>>>  tools/perf/util/annotate/Build     |   3 +
>>>>>>>  tools/perf/util/annotate/arm.c     |  50 +++++++
>>>>>>>  tools/perf/util/annotate/powerpc.c |  63 +++++++++
>>>>>>>  tools/perf/util/annotate/x86.c     | 107 +++++++++++++++
>>>>>> We already have a per arch area: tools/perf/arch/
>>>>> I think this was done to support cross-arch annotate similar to the 
>>>>> remote unwind support with util/libunwind/
>>>> Yes, because tools/perf/arch/ will only include host arch code.
>>> Ok, thanks for clarifying.
>> Hi Arnaldo,
>>
>> Are you ok with this patchset. Please let me know if you want to respin it.
> We're in the merge window, and I'm having to deal with other patches
> requiring more work than I was expecting to invest on them, so no time
> to revisit this, sorry, but I have not forgot about it, will get back to
> it as time permits,

Sure, no issues. :)

-Ravi