Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933813AbcJQPBg (ORCPT ); Mon, 17 Oct 2016 11:01:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933594AbcJQPB0 (ORCPT ); Mon, 17 Oct 2016 11:01:26 -0400 Date: Mon, 17 Oct 2016 17:01:23 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Sebastian Andrzej Siewior , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 2/2] perf bench futex: add NUMA support Message-ID: <20161017150123.GA18595@krava> References: <20161016190803.3392-1-bigeasy@linutronix.de> <20161016190803.3392-2-bigeasy@linutronix.de> <20161017143821.GO12815@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017143821.GO12815@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 17 Oct 2016 15:01:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 35 On Mon, Oct 17, 2016 at 11:38:21AM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, Oct 16, 2016 at 09:08:03PM +0200, Sebastian Andrzej Siewior escreveu: > > By default the application uses malloc() and all available CPUs. This > > patch introduces NUMA support which means: > > - memory is allocated node local via numa_alloc_local() > > - all CPUs of the specified NUMA node are used. This is also true if the > > number of threads set is greater than the number of CPUs available on > > this node. > > > > Signed-off-by: Sebastian Andrzej Siewior > > --- > > tools/perf/bench/Build | 4 ++ > > tools/perf/bench/futex-hash.c | 87 ++++++++++++++++++++++++++++++++++++++----- > > 2 files changed, 81 insertions(+), 10 deletions(-) > > > > diff --git a/tools/perf/bench/Build b/tools/perf/bench/Build > > index 60bf11943047..9e6e518d7d62 100644 > > --- a/tools/perf/bench/Build > > +++ b/tools/perf/bench/Build > > @@ -1,3 +1,7 @@ > > +ifdef CONFIG_NUMA > > +CFLAGS_futex-hash.o += -DCONFIG_NUMA=1 > > +endif > > Jiri, do we really need this? I.e. aren't the CONFIG_FOO defines > available to tools? not directly ATM.. it's prepared for the .config customary setting feature meanwhile we set HAVE_* defines, like for CONFIG_NUMA we have: -DHAVE_LIBNUMA_SUPPORT you can check it in Makefile.config jirka