Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934287AbcJQPE7 (ORCPT ); Mon, 17 Oct 2016 11:04:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:43294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933512AbcJQPEv (ORCPT ); Mon, 17 Oct 2016 11:04:51 -0400 Date: Mon, 17 Oct 2016 12:04:42 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , Sebastian Andrzej Siewior , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 2/2] perf bench futex: add NUMA support Message-ID: <20161017150442.GQ12815@kernel.org> References: <20161016190803.3392-1-bigeasy@linutronix.de> <20161016190803.3392-2-bigeasy@linutronix.de> <20161017143821.GO12815@kernel.org> <20161017150123.GA18595@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017150123.GA18595@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 38 Em Mon, Oct 17, 2016 at 05:01:23PM +0200, Jiri Olsa escreveu: > On Mon, Oct 17, 2016 at 11:38:21AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sun, Oct 16, 2016 at 09:08:03PM +0200, Sebastian Andrzej Siewior escreveu: > > > By default the application uses malloc() and all available CPUs. This > > > patch introduces NUMA support which means: > > > - memory is allocated node local via numa_alloc_local() > > > - all CPUs of the specified NUMA node are used. This is also true if the > > > number of threads set is greater than the number of CPUs available on > > > this node. > > > > > > Signed-off-by: Sebastian Andrzej Siewior > > > --- > > > tools/perf/bench/Build | 4 ++ > > > tools/perf/bench/futex-hash.c | 87 ++++++++++++++++++++++++++++++++++++++----- > > > 2 files changed, 81 insertions(+), 10 deletions(-) > > > > > > diff --git a/tools/perf/bench/Build b/tools/perf/bench/Build > > > index 60bf11943047..9e6e518d7d62 100644 > > > --- a/tools/perf/bench/Build > > > +++ b/tools/perf/bench/Build > > > @@ -1,3 +1,7 @@ > > > +ifdef CONFIG_NUMA > > > +CFLAGS_futex-hash.o += -DCONFIG_NUMA=1 > > > +endif > > > > Jiri, do we really need this? I.e. aren't the CONFIG_FOO defines > > available to tools? > > not directly ATM.. it's prepared for the .config customary setting feature > > meanwhile we set HAVE_* defines, like for CONFIG_NUMA we have: > -DHAVE_LIBNUMA_SUPPORT > > you can check it in Makefile.config So, Andrzej, can you use that instead? I merged the first patch already. - Arnaldo