Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757993AbcJQPbf (ORCPT ); Mon, 17 Oct 2016 11:31:35 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:32907 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754614AbcJQPb2 (ORCPT ); Mon, 17 Oct 2016 11:31:28 -0400 Date: Mon, 17 Oct 2016 17:31:25 +0200 From: Johan Hovold To: Pankaj Bharadiya Cc: gregkh@linuxfoundation.org, vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: Rename cport with intf_id Message-ID: <20161017153125.GD23255@localhost> References: <1476611954-11318-1-git-send-email-pankaj.bharadiya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476611954-11318-1-git-send-email-pankaj.bharadiya@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 17 On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion. Please be more specific about what these other things are; in this case sysfs attributes, uevent vars, and an odd-looking sysfs-string interface (more?). Wouldn't this change break any current user-space implementation? Also why aren't any of these attributes documented as they should be? Thanks, Johan