Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935453AbcJQQI2 (ORCPT ); Mon, 17 Oct 2016 12:08:28 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:56839 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932682AbcJQQIS (ORCPT ); Mon, 17 Oct 2016 12:08:18 -0400 From: Laurent Pinchart To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Date: Mon, 17 Oct 2016 19:08:13 +0300 Message-ID: <2535984.sVSHUQ4vnW@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1476719053-17600-2-git-send-email-javier@osg.samsung.com> References: <1476719053-17600-1-git-send-email-javier@osg.samsung.com> <1476719053-17600-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 52 Hi Javier, Thank you for the patch. On Monday 17 Oct 2016 12:44:08 Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias > alias: vsp1 > > After this patch: > > $ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias > alias: vsp1 > alias: of:N*T*Crenesas,vsp2C* > alias: of:N*T*Crenesas,vsp2 > alias: of:N*T*Crenesas,vsp1C* > alias: of:N*T*Crenesas,vsp1 > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Laurent Pinchart > --- > > drivers/media/platform/vsp1/vsp1_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c > b/drivers/media/platform/vsp1/vsp1_drv.c index 57c713a4e1df..aa237b48ad55 > 100644 > --- a/drivers/media/platform/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > @@ -770,6 +770,7 @@ static const struct of_device_id vsp1_of_match[] = { > { .compatible = "renesas,vsp2" }, > { }, > }; > +MODULE_DEVICE_TABLE(of, vsp1_of_match); > > static struct platform_driver vsp1_platform_driver = { > .probe = vsp1_probe, -- Regards, Laurent Pinchart