Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934989AbcJQQ3J (ORCPT ); Mon, 17 Oct 2016 12:29:09 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:37785 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933692AbcJQQ3F (ORCPT ); Mon, 17 Oct 2016 12:29:05 -0400 Date: Mon, 17 Oct 2016 18:29:01 +0200 From: Sebastian Andrzej Siewior To: Mike Galbraith Cc: Thomas Gleixner , LKML , linux-rt-users , Steven Rostedt Subject: Re: [patch] drivers/zram: Don't disable preemption in zcomp_stream_get/put() Message-ID: <20161017162900.y337rfe6ydmolbn3@linutronix.de> References: <20161006085228.jl6rpszdp5c2p2nr@linutronix.de> <1476587662.1538.8.camel@gmail.com> <20161017142428.25dyxefk2arjeyfz@linutronix.de> <1476721140.30636.10.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1476721140.30636.10.camel@gmail.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 369 Lines: 11 On 2016-10-17 18:19:00 [+0200], Mike Galbraith wrote: > I used a local lock first, but lockdep was unhappy with it. Ok, back > to the drawing board. Seems to work, but... locallock can be taken recursively so unless preemption was already disabled, lockdep shouldn't complain. But then from the small context it should not be taken recursively. > -Mike Sebastian