Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030277AbcJQQv0 (ORCPT ); Mon, 17 Oct 2016 12:51:26 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33827 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935913AbcJQQvV (ORCPT ); Mon, 17 Oct 2016 12:51:21 -0400 Date: Mon, 17 Oct 2016 18:51:17 +0200 From: Johan Hovold To: Wei Yongjun Cc: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Wei Yongjun , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state() Message-ID: <20161017165117.GA2765@localhost> References: <1476722240-23063-1-git-send-email-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476722240-23063-1-git-send-email-weiyj.lk@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 484 Lines: 17 On Mon, Oct 17, 2016 at 04:37:20PM +0000, Wei Yongjun wrote: > From: Wei Yongjun > > This node pointer is returned by of_find_compatible_node() with > refcount incremented in this function. of_node_put() on it before > exitting this function. > > This is detected by Coccinelle semantic patch. > > Signed-off-by: Wei Yongjun This code is going away eventually, but still. Acked-by: Johan Hovold Thanks, Johan