Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933255AbcJQQ4b (ORCPT ); Mon, 17 Oct 2016 12:56:31 -0400 Received: from mailapp02.imgtec.com ([217.156.133.132]:39861 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965259AbcJQQxJ (ORCPT ); Mon, 17 Oct 2016 12:53:09 -0400 From: Zubair Lutfullah Kakakhel To: , , , , , , CC: , , , , , , , Subject: [Patch v5 05/12] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided Date: Mon, 17 Oct 2016 17:52:49 +0100 Message-ID: <1476723176-39891-6-git-send-email-Zubair.Kakakhel@imgtec.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476723176-39891-1-git-send-email-Zubair.Kakakhel@imgtec.com> References: <1476723176-39891-1-git-send-email-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.154.45] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 30 The powerpc dts file upstream does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel --- V5 new patch --- drivers/irqchip/irq-xilinx-intc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c index dbf8b0c..485fb11 100644 --- a/drivers/irqchip/irq-xilinx-intc.c +++ b/drivers/irqchip/irq-xilinx-intc.c @@ -197,8 +197,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, ret = of_property_read_u32(intc, "xlnx,kind-of-intr", &irqc->intr_mask); if (ret < 0) { - pr_err("%s: unable to read xlnx,kind-of-intr\n", __func__); - goto err_alloc; + pr_warn("%s: unable to read xlnx,kind-of-intr\n", __func__); + irqc->intr_mask = 0; } if (irqc->intr_mask >> nr_irq) -- 1.9.1