Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965284AbcJQQ7t (ORCPT ); Mon, 17 Oct 2016 12:59:49 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:49839 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965222AbcJQQ7h (ORCPT ); Mon, 17 Oct 2016 12:59:37 -0400 Subject: Re: Build regressions/improvements in v4.9-rc1 To: Geert Uytterhoeven , "linux-kernel@vger.kernel.org" References: <1476688913-15648-1-git-send-email-geert@linux-m68k.org> CC: arcml , Michael Ellerman , Peter Zijlstra , Arnd Bergmann , Michal Marek Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc,gmane.linux.ports.ppc64.devel From: Vineet Gupta Message-ID: <00b16c44-79b8-43b8-6516-13c8bb92eb03@synopsys.com> Date: Mon, 17 Oct 2016 09:59:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.50] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 33 +CC Arnd, Michal Hi Geert, Arnd Need some guidance here. On 10/17/2016 12:34 AM, Geert Uytterhoeven wrote: >> 48 error regressions: >> > + /home/kisskb/slave/src/arch/arc/include/asm/atomic.h: Error: bad instruction `llockd r2,[r0]': => 476 >> > + /home/kisskb/slave/src/arch/arc/include/asm/atomic.h: Error: bad instruction `llockd r2,[r13]': => 475 [snip...] >> > + /home/kisskb/slave/src/arch/arc/include/asm/atomic.h: Error: bad instruction `scondd r4,[r8]': => 516 >> > + /home/kisskb/slave/src/arch/arc/include/asm/atomic.h: Error: bad instruction `scondd r6,[r3]': => 478 > arcv2/axs103_smp_defconfig I'm thinking how to address this correctly. This is due to the older version of compiler. The fix itself is trivial - add an "call as-instr" construct in Makefile to get -DARC_TOOLS_SUPPORT_LLOCKD However the atomic64 API variant (CONFIG_GENERIC_ATOMIC64 or arch native) which gets included in build comes from Kconfig (ISA supports them or not). How do we tie the Makefile info into the Kconfig. We could trigger a build failure for invalid combinations of GENERIC_ATOMIC64 and ARC_TOOLS_SUPPORT_LLOCKD but that would be less than ideal out of box experience. Or the simpler solution is that kisskb upgrades the ARC GNU compiler ;-) -Vineet