Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936594AbcJQRX7 (ORCPT ); Mon, 17 Oct 2016 13:23:59 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:50518 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755705AbcJQRXu (ORCPT ); Mon, 17 Oct 2016 13:23:50 -0400 Subject: Re: ARC-setup: Use seq_putc() in show_cpuinfo() To: SF Markus Elfring References: <164a402a-de20-645d-00af-9a414cf745c4@users.sourceforge.net> <579aaf85-c22d-b680-5ce8-3c0e23ab6d7e@synopsys.com> CC: "linux-snps-arc@lists.infradead.org" , Alexey Brodkin , Andrea Gelmini , Kefeng Wang , "Noam Camus" , LKML , "kernel-janitors@vger.kernel.org" From: Vineet Gupta Message-ID: <10542905-ebe1-49f5-190b-3783137e7854@synopsys.com> Date: Mon, 17 Oct 2016 10:23:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.50] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 22 On 10/17/2016 10:19 AM, SF Markus Elfring wrote: >>> A single character (line break) should be put into a sequence. >>> Thus use the corresponding function "seq_putc". >> Perhaps reword the changelog to say that seqc_putc is more efficient than >> seqc_printf to output a single char. >> I mean _printf is not wrong but not as efficient ? > I came along source files for a few other software modules with similar > change possibilities. > Unfortunately, the corresponding developers are not convinced yet > to replace a call of the function "seq_printf" at the end by > a "seq_putc" because of software efficiency reasons. I was ambivalent so far - but not anymore :-) what is the objection - can you point me to a few links where people don't think this is not a good idea. > Do you find this update suggestion acceptable to some degree > for the function "setup"? > > Regards, > Markus >