From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
CC: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] DAX: enable iostat for read/write
Thread-Topic: [PATCH v2] DAX: enable iostat for read/write
Thread-Index: AQHSKJrRCx+SUa1F6Ue+SkLsEIABZ6Cs5vOAgAADw4A=
Date: Mon, 17 Oct 2016 17:45:04 +0000
Message-ID: <1476726205.20881.72.camel@hpe.com>
References: <1476724738-19133-1-git-send-email-toshi.kani@hpe.com>
         <20161017172957.GC25175@linux.intel.com>
In-Reply-To: <20161017172957.GC25175@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <7AA5AB08D4FFCF4D8118B3DF6ACF59C3@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2016 17:45:04.8461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0005
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9HHjIwL004734
Content-Length: 1025
Lines: 29

On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote:
> On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote:
> > 
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> > 
> > Add iostat support to the DAX read/write path.
> > 
> > Note, iostat still does not support the DAX mmap path as it allows
> > user applications to access directly.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > v2:
> > - Set a minimum of one sector (Dan Williams)
> 
> What about Dave's feedback that this code just reimplements 
> generic_start_io_acct() and generic_end_io_acct()?

My bad. There was some issue in my email box and I just realized it.
Please disregard this version... 

Thanks,
-Toshi