Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758953AbcJQTJ5 (ORCPT ); Mon, 17 Oct 2016 15:09:57 -0400 Received: from up.free-electrons.com ([163.172.77.33]:38146 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758925AbcJQTJq (ORCPT ); Mon, 17 Oct 2016 15:09:46 -0400 X-Greylist: delayed 524 seconds by postgrey-1.27 at vger.kernel.org; Mon, 17 Oct 2016 15:09:45 EDT Date: Mon, 17 Oct 2016 21:00:49 +0200 From: Alexandre Belloni To: Peter Rosin Cc: Nicolas Ferre , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman Subject: Re: Regression: usb serial gadget on sama5d3 broken Message-ID: <20161017190049.d2kw7kua7crysuvs@piout.net> References: <569c65cd-4e2e-4455-c24c-074f8c5fd315@axentia.se> <38ca0db7-9bc6-7258-b102-ea9fdeb9b03c@atmel.com> <621565bc-2fa0-bbd1-80cd-6c9b2a494faa@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <621565bc-2fa0-bbd1-80cd-6c9b2a494faa@axentia.se> User-Agent: NeoMutt/20160916 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 45 On 17/10/2016 at 19:50:48 +0200, Peter Rosin wrote : > On 2016-10-17 16:54, Nicolas Ferre wrote: > > Le 17/10/2016 ? 14:53, Peter Rosin a ?crit : > >> Hi! > >> > >> I'm suffering from a regression while using the usb gadget port on the > >> sama5d3 to get terminal access to the device in question (CONFIG_USB_G_SERIAL). > >> > >> I get this message when I try to connect: > >> udc: ep: Invalid setup request: 02.01 v0000 i0081 l0, halting endpoint... > >> > >> A bisect blames commit v4.7-rc1-21-gc32b5bcfa3c4 "ARM: dts: at91: Fix > >> USB endpoint nodes". > >> > >> And indeed, reverting that commit on top of v4.9-rc1 fixes things, > >> although that doesn't look like the best of fixes... > >> > >> BTW, the bisect was extremely painful since v4.7-rc1 seemed broken > >> somewhere in the overlayfs area. I hope I will never ever need to bisect > >> in the v4.6..v4.7 area again. This was the second time, the first time > >> I was chasing a gpio interrupt bug, but I never found out what was wrong > >> and stopped looking when v4.9-rc1 turned out to be ok even though v4.8 > >> was bad, it was just too painful to look for things that already seemed > >> fixed. > > > > I guess that you are referring to the regression listed here: > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1239220.html > > > > The patch is available and will hopefully land in an official kernel > > soon (4.8.1) as said by Felipe and Greg. > > > > Sorry for the inconvenience. Best regards, > > Ok, I tried "usb: gadget: udc: atmel: fix endpoint name" and it fixes > things for me too. But shouldn't the memory for the now dynamic name be > allocated with devm_kasprintf instead of that plain kasprint? If you > are pedantic... > That wouldn't be a bad idea. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com