Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758978AbcJQTKI (ORCPT ); Mon, 17 Oct 2016 15:10:08 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33984 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758943AbcJQTJy (ORCPT ); Mon, 17 Oct 2016 15:09:54 -0400 Subject: Re: [PATCH 4/4] gpio: ptxpmb-ext-cpld: Document bindings of PTXPMB extended CPLD Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 From: Pantelis Antoniou In-Reply-To: <20161010201936.GB32418@rob-hp-laptop> Date: Mon, 17 Oct 2016 22:10:01 +0300 Cc: Lee Jones , Linus Walleij , Alexandre Courbot , Mark Rutland , Frank Rowand , Georgi Vlaev , Guenter Roeck , JawaharBalaji Thirumalaisamy , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-watchdog@vger.kernel.org, netdev@vger.kernel.org Message-Id: References: <1475853574-22339-1-git-send-email-pantelis.antoniou@konsulko.com> <1475853574-22339-5-git-send-email-pantelis.antoniou@konsulko.com> <20161010201936.GB32418@rob-hp-laptop> To: Rob Herring X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9HJAHT6005175 Content-Length: 2209 Lines: 80 Hi Rob, > On Oct 10, 2016, at 23:19 , Rob Herring wrote: > > On Fri, Oct 07, 2016 at 06:19:34PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Add device tree bindings document for the GPIO driver of >> Juniper's PTXPMB extended CPLD. >> >> Signed-off-by: Georgi Vlaev >> [Ported from Juniper kernel] >> Signed-off-by: Pantelis Antoniou >> --- >> .../bindings/gpio/jnx,gpio-ptxpmb-ext-cpld.txt | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/jnx,gpio-ptxpmb-ext-cpld.txt >> >> diff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-ptxpmb-ext-cpld.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-ptxpmb-ext-cpld.txt >> new file mode 100644 >> index 0000000..87f01b9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-ptxpmb-ext-cpld.txt >> @@ -0,0 +1,36 @@ >> +Juniper PTXPMB extended CPLD GPIO block >> + >> +Required properties: >> + >> +- compatible: >> + Must be "jnx,gpio-ptxpmb-ext-cpld" > > Generally, '-gpio' would be last. > OK. >> + >> +- #gpio-cells: >> + Should be <2>. The first cell is the pin number (within the controller's >> + pin space), and the second is used for the following flags: >> + bit[0]: direction (0 = out, 1 = in) >> + bit[1]: init high >> + bit[2]: active low > > Same comment as all the other gpio bindings... > >> + >> +- gpio-controller: >> + Specifies that the node is a GPIO controller. >> + >> +- interrupt-controller: >> + Specifies that the node is an interrupt controller. >> + >> +Optional properties: >> + >> +- reg: >> + Address and length of the register set for the device. Usually supplied >> + by the parent MFD device. > > Make it required. > Hmm, the current driver supplies that range via platform data (it’s an mfd driver). What’s the take on mixing those? >> + >> + >> +Example: >> + >> +gpio_ext_cpld: cpld-ext-gpio { >> + compatible = "jnx,gpio-ptxpmb-ext-cpld"; >> + #gpio-cells = <2>; >> + #interrupt-cells = <2>; >> + gpio-controller; >> + interrupt-controller; >> +}; >> -- >> 1.9.1