Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935211AbcJQTPa (ORCPT ); Mon, 17 Oct 2016 15:15:30 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:35851 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934666AbcJQTPV (ORCPT ); Mon, 17 Oct 2016 15:15:21 -0400 Subject: Re: [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: Pantelis Antoniou In-Reply-To: <20161017135957.20297-1-ralf@ramses-pyramidenbau.de> Date: Mon, 17 Oct 2016 22:15:27 +0300 Cc: Mark Brown , Geert Uytterhoeven , Wolfram Sang , Linux SPI , Linux I2C , "linux-kernel @ vger . kernel . org" Message-Id: <72515578-AF72-4F37-AB69-EC1930D27FF4@konsulko.com> References: <20161017135957.20297-1-ralf@ramses-pyramidenbau.de> To: Ralf Ramsauer X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9HJFYrj005208 Content-Length: 1037 Lines: 39 Hi Ralf, > On Oct 17, 2016, at 16:59 , Ralf Ramsauer wrote: > > Hi, > > this one fixes initialisation of I2C/SPI nodes. Upon failure during > intialisation, nodes were erroneously populated and never unmarked. > > This lead to the problem that re-loaded drivers will never probe those devices > again and can easily be fixed by clearing the OF_POPULATE flag when the node > doesn't successfully initialise. > > For the discussion of v1, see > https://lkml.org/lkml/2016/10/14/483 > > Ralf > > changes since v1: > - also fix I2C core driver > - keep the atomic test-and-set, as Geert suggested > > Ralf Ramsauer (2): > spi: mark device nodes only in case of successful instantiation > i2c: mark device nodes only in case of successful instantiation > > drivers/i2c/i2c-core.c | 11 ++++++++++- > drivers/spi/spi.c | 5 ++++- > 2 files changed, 14 insertions(+), 2 deletions(-) > > -- > 2.10.1 > Thanks for catching this. Acked-by: Pantelis Antoniou