Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbcJQUDw (ORCPT ); Mon, 17 Oct 2016 16:03:52 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873AbcJQUDo (ORCPT ); Mon, 17 Oct 2016 16:03:44 -0400 Date: Mon, 17 Oct 2016 16:03:41 -0400 (EDT) Message-Id: <20161017.160341.529517225075047124.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking From: David Miller In-Reply-To: <20161017195417.48259-1-jarod@redhat.com> References: <20161017195417.48259-1-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Oct 2016 13:03:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 21 From: Jarod Wilson Date: Mon, 17 Oct 2016 15:54:02 -0400 > For the most part, every patch does the same essential thing: removes the > MTU range checking from the drivers' ndo_change_mtu function, puts those > ranges into the core net_device min_mtu and max_mtu fields, and where > possible, removes ndo_change_mtu functions entirely. Jarod, please read my other posting. You've positively broken the maximum MTU for all of these drivers. That's not cool. And this series fixing things doesn't make things better, because now we've significanyly broken bisection for anyone running into this regression. You should have arranged this in such a way that the drivers needing > 1500 byte MTU were not impacted at all by your changes, but that isn't what happened.