Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758926AbcJQUVE (ORCPT ); Mon, 17 Oct 2016 16:21:04 -0400 Received: from mx4.wp.pl ([212.77.101.12]:21346 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758852AbcJQUVC (ORCPT ); Mon, 17 Oct 2016 16:21:02 -0400 Date: Mon, 17 Oct 2016 21:20:57 +0100 From: Jakub Kicinski To: Jarod Wilson Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Kirsher Subject: Re: [PATCH net-next 03/15] ethernet/intel: use core min/max MTU checking Message-ID: <20161017212057.42d4e91f@jkicinski-Precision-T1700> In-Reply-To: <20161017195417.48259-4-jarod@redhat.com> References: <20161017195417.48259-1-jarod@redhat.com> <20161017195417.48259-4-jarod@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 1cf06af2984c8b770c62941843b9817d X-WP-AV: skaner antywirusowy poczty Nowej Poczty X-WP-SPAM: NO 000000A [cSPU] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 459 Lines: 12 Looks better, unfortunately, I can't test since net-next also seem to make nfs implode on my setup. On Mon, 17 Oct 2016 15:54:05 -0400, Jarod Wilson wrote: > @@ -7187,6 +7180,11 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > netdev->vlan_features |= NETIF_F_HIGHDMA; > } > > + /* MTU range: 68 - max_hw_frame_size */ > + netdev->min_mtu = ETH_MIN_MTU; Nitpick: we probably don't have to reinit min_mtu if it's 68.