Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932904AbcJQVqp (ORCPT ); Mon, 17 Oct 2016 17:46:45 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34345 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932620AbcJQVqk (ORCPT ); Mon, 17 Oct 2016 17:46:40 -0400 MIME-Version: 1.0 In-Reply-To: <20161017082931.GA17106@kroah.com> References: <1476465777-720-1-git-send-email-fernando.apesteguia@gmail.com> <20161017082931.GA17106@kroah.com> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Mon, 17 Oct 2016 23:46:36 +0200 Message-ID: Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro To: Greg KH Cc: Lidza Louina , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2523 Lines: 65 On Mon, Oct 17, 2016 at 10:29 AM, Greg KH wrote: > On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: >> The patch replaces the macro with a function (dgnc_get_board) and >> substitutes the macro statement with a call to that function and a >> comparison on the returned value. >> >> This removes a checkpatch warning. >> >> Signed-off-by: Fernando Apesteguia >> --- >> drivers/staging/dgnc/dgnc_sysfs.c | 74 +++++++++++++++++++++++++++------------ >> 1 file changed, 51 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c >> index 290bf6e..3ea23a9 100644 >> --- a/drivers/staging/dgnc/dgnc_sysfs.c >> +++ b/drivers/staging/dgnc/dgnc_sysfs.c >> @@ -90,17 +90,21 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) >> driver_remove_file(driverfs, &driver_attr_pollrate); >> } >> >> -#define DGNC_VERIFY_BOARD(p, bd) \ >> - do { \ >> - if (!p) \ >> - return 0; \ >> - \ >> - bd = dev_get_drvdata(p); \ >> - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ >> - return 0; \ >> - if (bd->state != BOARD_READY) \ >> - return 0; \ >> - } while (0) >> +static struct dgnc_board *dgnc_get_board(struct device *p) >> +{ >> + struct dgnc_board *bd; >> + >> + if (!p) >> + return NULL; >> + >> + bd = dev_get_drvdata(p); >> + if (!bd || bd->magic != DGNC_BOARD_MAGIC) >> + return NULL; >> + if (bd->state != BOARD_READY) >> + return NULL; >> + >> + return bd; >> +} > > No, this macro should be removed entirely as what it does is pointless > in some parts, wrong in others, and not needed at all in the rest :( > > I've asked others to fix this up properly in the past, but it doesn't > seem like anyone wants to do the work... > I tried to find the discussion the relevant mails in lkml.org but couldn't find them. Could you point me to them so I can have a look? Thanks. > I don't want to take this patch as it will hide the real issues here. > > thanks, > > greg k-h