Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933918AbcJQWEA (ORCPT ); Mon, 17 Oct 2016 18:04:00 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34397 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933728AbcJQWDs (ORCPT ); Mon, 17 Oct 2016 18:03:48 -0400 MIME-Version: 1.0 X-Originating-IP: [209.133.79.5] In-Reply-To: <464e62ad-476e-5a2b-cdb4-c4e7f7f34e7d@broadcom.com> References: <1475959264-16582-1-git-send-email-scott.branden@broadcom.com> <8265935.TobkRj9BnG@wuerfel> <464e62ad-476e-5a2b-cdb4-c4e7f7f34e7d@broadcom.com> From: Olof Johansson Date: Mon, 17 Oct 2016 15:03:47 -0700 Message-ID: Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable Intel e1000e driver To: Scott Branden Cc: Arnd Bergmann , Russell King , Florian Fainelli , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BCM Kernel Feedback , Ray Jui Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 29 On Tue, Oct 11, 2016 at 3:38 PM, Scott Branden wrote: > Hi Arnd, > > On 16-10-10 12:47 AM, Arnd Bergmann wrote: >> >> On Saturday, October 8, 2016 1:41:04 PM CEST Scott Branden wrote: >>> >>> Enable support for the Intel e1000e driver >>> >>> Signed-off-by: Ray Jui >>> Signed-off-by: Scott Branden >>> >> >> Can we make this a loadable module and group it with the other >> ethernet drivers? >> > We use a fixed rootfs image to test the kernel. For simplicity we don't > construct a rootfs or load any modules. We just test the kernel image. So > for us every defconfig we use needs to be set to y to use the upstreamed > kernel. > > Plus, how do you NFS mount a rootfs if the ethernet driver is a loadable > module? Yeah, agreed that it makes sense to enable it here. Applied to fixes. -Olof