Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759631AbcJQWWW (ORCPT ); Mon, 17 Oct 2016 18:22:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54001 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759587AbcJQWVx (ORCPT ); Mon, 17 Oct 2016 18:21:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 67E4061271 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 17 Oct 2016 15:21:50 -0700 From: Stephen Boyd To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , Michael Turquette , Chanwoo Choi , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Tomasz Figa , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] clk: samsung: clk-exynos-audss: Fix module autoload Message-ID: <20161017222150.GE8871@codeaurora.org> References: <1476625507-21377-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476625507-21377-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 37 On 10/16, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/clk/samsung/clk-exynos-audss.ko | grep alias > alias: platform:exynos-audss-clk > > After this patch: > > $ modinfo drivers/clk/samsung/clk-exynos-audss.ko | grep alias > alias: platform:exynos-audss-clk > alias: of:N*T*Csamsung,exynos5420-audss-clockC* > alias: of:N*T*Csamsung,exynos5420-audss-clock > alias: of:N*T*Csamsung,exynos5410-audss-clockC* > alias: of:N*T*Csamsung,exynos5410-audss-clock > alias: of:N*T*Csamsung,exynos5250-audss-clockC* > alias: of:N*T*Csamsung,exynos5250-audss-clock > alias: of:N*T*Csamsung,exynos4210-audss-clockC* > alias: of:N*T*Csamsung,exynos4210-audss-clock > > Fixes: 4d252fd5719b ("clk: samsung: Allow modular build of the Audio Subsystem CLKCON driver") > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- Applied to clk-fixes -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project