Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933577AbcJQWai (ORCPT ); Mon, 17 Oct 2016 18:30:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56698 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310AbcJQWab (ORCPT ); Mon, 17 Oct 2016 18:30:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org AE45E61185 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 17 Oct 2016 15:30:30 -0700 From: Stephen Boyd To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Markus Reichl , Tobias Jakobi , Michael Turquette , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Message-ID: <20161017223030.GI8871@codeaurora.org> References: <1475765999-14366-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475765999-14366-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 27 On 10/06, Javier Martinez Canillas wrote: > The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and > registration APIs") converted the driver to use the new provider API to > register clocks using clk_hw. > > But unfortunately, in the conversion it missed to set the num_clks value > which lead to the following error when trying to register a clk provider: > > [ 1.963782] of_clk_max77686_get: invalid index 0 > [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1) > [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock > > Fix it by correctly set the max77686_clk_driver_data num_clks member. > > Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs") > Reported-by: Markus Reichl > Suggested-by: Tobias Jakobi > Signed-off-by: Javier Martinez Canillas > Tested-by: Markus Reichl > > --- Applied to clk-fixes -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project