Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755659AbcJRCYa (ORCPT ); Mon, 17 Oct 2016 22:24:30 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:33011 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbcJRCYW (ORCPT ); Mon, 17 Oct 2016 22:24:22 -0400 MIME-Version: 1.0 In-Reply-To: <20161017150356.7dd37cae@gandalf.local.home> References: <98ebf1ca60f0af8a4e56b67bedd197e0b4e85c0a.1476182683.git.baolin.wang@linaro.org> <20161017150356.7dd37cae@gandalf.local.home> From: Baolin Wang Date: Tue, 18 Oct 2016 10:24:21 +0800 Message-ID: Subject: Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer To: Steven Rostedt Cc: Ingo Molnar , John Stultz , Thomas Gleixner , Mark Brown , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 51 On 18 October 2016 at 03:03, Steven Rostedt wrote: > On Tue, 11 Oct 2016 18:48:16 +0800 > Baolin Wang wrote: > >> --- >> Changes since v2: >> - Save time as s64 type. >> - Remove 'process_name' parameter and add 'now' parameter. >> - Rename the trace event name. >> - Remove restart trace event. >> - Other optimization. >> --- >> include/trace/events/alarmtimer.h | 92 +++++++++++++++++++++++++++++++++++++ >> kernel/time/alarmtimer.c | 16 ++++++- >> 2 files changed, 106 insertions(+), 2 deletions(-) >> create mode 100644 include/trace/events/alarmtimer.h >> >> diff --git a/include/trace/events/alarmtimer.h b/include/trace/events/alarmtimer.h >> new file mode 100644 >> index 0000000..4c92a3e >> --- /dev/null >> +++ b/include/trace/events/alarmtimer.h >> @@ -0,0 +1,92 @@ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM alarmtimer >> + >> +#if !defined(_TRACE_ALARMTIMER_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_ALARMTIMER_H >> + >> +#include >> +#include >> +#include >> + >> +TRACE_DEFINE_ENUM(ALARM_REALTIME); >> +TRACE_DEFINE_ENUM(ALARM_BOOTTIME); >> + >> +#define show_alarm_type(type) __print_flags(type, " | ", \ >> + { 1 << ALARM_REALTIME, "ALARM_REALTIME" }, \ >> + { 1 << ALARM_BOOTTIME, "ALARM_BOOTTIME" }) > > Why have the "ALARM_" prefix in the string? We already know that these > are "alarm" tracepoints. They just make the lines longer than they need > to be. > > Other than that, from a tracing point of view, this looks fine to me. Thanks Steven. I will remove the prefix and add your ACK in next version. -- Baolin.wang Best Regards