Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932712AbcJRC2o (ORCPT ); Mon, 17 Oct 2016 22:28:44 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35237 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755249AbcJRC2g (ORCPT ); Mon, 17 Oct 2016 22:28:36 -0400 MIME-Version: 1.0 In-Reply-To: <20161017074644.GB7010@kroah.com> References: <1476647035-23634-1-git-send-email-pankaj.bharadiya@gmail.com> <20161017074644.GB7010@kroah.com> From: Pankaj Bharadiya Date: Tue, 18 Oct 2016 07:58:34 +0530 Message-ID: Subject: Re: [PATCH] staging: dgnc: Replace CamelCase namings with underscores. To: Greg KH Cc: Lidza Louina , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1630 Lines: 53 On Mon, Oct 17, 2016 at 1:16 PM, Greg KH wrote: > > On Mon, Oct 17, 2016 at 01:13:55AM +0530, Pankaj Bharadiya wrote: > > Replace CamelCase names with underscores to comply with the standard > > kernel coding style. > > > > Signed-off-by: Pankaj Bharadiya > > --- > > drivers/staging/dgnc/dgnc_tty.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > > index ef9a45b..1a21902 100644 > > --- a/drivers/staging/dgnc/dgnc_tty.c > > +++ b/drivers/staging/dgnc/dgnc_tty.c > > @@ -45,7 +45,7 @@ > > /* > > * internal variables > > */ > > -static unsigned char *dgnc_TmpWriteBuf; > > +static unsigned char *dgnc_tmp_write_buf; > > Why not just fix the code to not have this variable at all? It's not > correct to have it from what I can tell... > > Also, you modify many different variables all at once, can you please > just modify one at a time (one per patch), to make it more obvious it is > correct? > > > /* > > * Default transparent print information. > > @@ -69,7 +69,7 @@ > > * This defines a raw port at 9600 baud, 8 data bits, no parity, > > * 1 stop bit. > > */ > > -static struct ktermios DgncDefaultTermios = { > > +static struct ktermios dgnc_default_termios = { > > rename to "default_termios"? > > No need to keep the driver name prefix on a static variable, right? > Hi Greg, Thank you for your comments. I have submitted v2 patchset. I hope that makes more sense now. Thanks, Pankaj > thanks, > > greg k-h