From: Arnd Bergmann <arnd@arndb.de>
To: Haggai Eran <haggaie@mellanox.com>
Cc: Doug Ledford <dledford@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Matan Barak <matanb@mellanox.com>, Leon Romanovsky <leon@kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        Alex Vesker <valex@mellanox.com>, Guy Shapiro <guysh@mellanox.com>,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH 03/28] [v2] infiniband: shut up a maybe-uninitialized warning
Date: Tue, 18 Oct 2016 12:18:55 +0200
Message-ID: <9469876.gij7f9Mh1b@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <33302790-0a4c-e2b3-868d-3e7dadbd3c07@mellanox.com>
References: <20161017220342.1627073-1-arnd@arndb.de> <20161017220557.1688282-3-arnd@arndb.de> <33302790-0a4c-e2b3-868d-3e7dadbd3c07@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 801
Lines: 17

On Tuesday, October 18, 2016 9:47:31 AM CEST Haggai Eran wrote:
> On 10/18/2016 1:05 AM, Arnd Bergmann wrote:
> > @@ -1309,7 +1311,7 @@ static bool validate_net_dev(struct net_device *net_dev,
> >  static struct net_device *cma_get_net_dev(struct ib_cm_event *ib_event,
> >                                         const struct cma_req_info *req)
> >  {
> > -     struct sockaddr_storage listen_addr_storage, src_addr_storage;
> > +     struct sockaddr_storage listen_addr_storage = {}, src_addr_storage = {};
> 
> Doesn't this still translate to an extra initialization that Doug was
> worried about?

Thanks for spotting this. I must have screwed up while rebasing the patch
at some point, this one change should not be there, the other changes by
themselves sufficiently address the warning.

	Arnd