Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757903AbcJRMQL (ORCPT ); Tue, 18 Oct 2016 08:16:11 -0400 Received: from merlin.infradead.org ([205.233.59.134]:56894 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089AbcJRMQE (ORCPT ); Tue, 18 Oct 2016 08:16:04 -0400 Date: Tue, 18 Oct 2016 14:15:57 +0200 From: Peter Zijlstra To: Matt Fleming Cc: Vincent Guittot , Wanpeng Li , Ingo Molnar , "linux-kernel@vger.kernel.org" , Mike Galbraith , Yuyang Du , Dietmar Eggemann Subject: Re: [PATCH] sched/fair: Do not decay new task load on first enqueue Message-ID: <20161018121557.GA3142@twins.programming.kicks-ass.net> References: <20160928101422.GR5016@twins.programming.kicks-ass.net> <20160928193731.GD16071@codeblueprint.co.uk> <20161010100107.GZ16071@codeblueprint.co.uk> <20161010173440.GA28945@linaro.org> <20161011102453.GA16071@codeblueprint.co.uk> <20161018102937.GI16071@codeblueprint.co.uk> <20161018111017.GY3142@twins.programming.kicks-ass.net> <20161018112957.GJ16071@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161018112957.GJ16071@codeblueprint.co.uk> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 22 On Tue, Oct 18, 2016 at 12:29:57PM +0100, Matt Fleming wrote: > On Tue, 18 Oct, at 01:10:17PM, Peter Zijlstra wrote: > > > > I'm entirely lost as to which patch we're talking about by now ;-) > > Heh, this one from Vincent, > > https://lkml.kernel.org/r/20161010173440.GA28945@linaro.org Ah, right. Seems like a sensible thing to do, and I suppose I should go finish my (and yours) update_rq_clock() patches that supersede the patch referred to in that thing and is depended upon. It might make sense to have helper functions to evaluate those conditions, because currently there's two instances of each, once in the branch selection and then again (but inverted, we miss the == case fwiw) in the return NULL case.