Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760954AbcJRN1z (ORCPT ); Tue, 18 Oct 2016 09:27:55 -0400 Received: from nbd.name ([46.4.11.11]:38776 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755336AbcJRN1q (ORCPT ); Tue, 18 Oct 2016 09:27:46 -0400 Subject: Re: [PATCH] net: dsa: properly disconnect the slave PHYs To: Andrew Lunn References: <1476792760-60356-1-git-send-email-john@phrozen.org> <20161018122909.GR26778@lunn.ch> <20161018132413.GU26778@lunn.ch> Cc: Vivien Didelot , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: John Crispin Message-ID: <08bfeefe-14bd-409a-3d05-7fd9fd26b5f3@phrozen.org> Date: Tue, 18 Oct 2016 15:27:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161018132413.GU26778@lunn.ch> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 25 On 18/10/2016 15:24, Andrew Lunn wrote: >> Hi Andrew >> >> i am testing on v4.4 which did not have a phy_disconnect() call. this >> seems to have been fixed by cda5c15b so please ignore this patch > > Hi John > > All patches must be against net-next, or net if it is a fix. Anything > else is wrong.... > > Andrew > Hi Andrew, i know. i was testing on v4.4 and then rebased the patch against net-next without noticing that a similar patch had already been merged. regardless, using the latest net-next tree, the oops is gone without adding any patches. John