Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760835AbcJRNwC (ORCPT ); Tue, 18 Oct 2016 09:52:02 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:37408 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609AbcJRNvx (ORCPT ); Tue, 18 Oct 2016 09:51:53 -0400 Subject: Re: [PATCH -next] unicore32: Fix build error To: Guan Xuetao References: <1476775476-17024-1-git-send-email-linux@roeck-us.net> Cc: Qin Rui , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <8d3a7b95-7a1d-1641-76dc-01db30497bd0@roeck-us.net> Date: Tue, 18 Oct 2016 06:51:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476775476-17024-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2007 Lines: 48 On 10/18/2016 12:24 AM, Guenter Roeck wrote: > Since the oldabi syscall interface was first introduced, the infrastructure > changed and the patch no longer compiles. See commit f56141e3e2d9a ("all > arches, signal: move restart_block to struct task_struct") for details. > > Fixes: 1ace5d1e3d4b4 ("unicore32-oldabi: add oldabi syscall interface") > Signed-off-by: Guenter Roeck > --- > Should be merged with the commit introducing the problem if possible. > Additional comment: Even with this patch applied, the image does not boot with qemu in -next. Here is a partial log: ... Memory: 441012K/524288K available (1923K kernel code, 76K rwdata, 312K rodata, 2212K init, 175K bss, 83276K reserved, 0K cma-reserved)^M Virtual kernel memory layout:^M vector : 0xffff0000 - 0xffff1000 ( 4 kB)^M vmalloc : 0xe0800000 - 0xff000000 ( 488 MB)^M lowmem : 0xc0000000 - 0xe0000000 ( 512 MB)^M modules : 0xbf000000 - 0xc0000000 ( 16 MB)^M .init : 0xc0408000 - 0xc0631000 (2212 kB)^M .text : 0xc0631000 - 0xc0811e20 (1924 kB)^M .data : 0xc0811e20 - 0xc0873160 ( 389 kB)^M ------------[ cut here ]------------^M WARNING: CPU: 0 PID: 0 at mm/percpu.c:996 pcpu_alloc+0x528/0x5d4^M The code then loops forever repeating this warning and the associated traceback. Guenter > arch/unicore32/kernel/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/unicore32/kernel/signal.c b/arch/unicore32/kernel/signal.c > index 78a66491b108..be75ef8c1e0c 100644 > --- a/arch/unicore32/kernel/signal.c > +++ b/arch/unicore32/kernel/signal.c > @@ -115,7 +115,7 @@ asmlinkage int __sys_sigreturn(struct pt_regs *regs) > struct sigframe __user *frame; > > /* Always make any pending restarted system calls return -EINTR */ > - current_thread_info()->restart_block.fn = do_no_restart_syscall; > + current->restart_block.fn = do_no_restart_syscall; > > /* > * Since we stacked the signal on a 64-bit boundary, >