Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761565AbcJROaX (ORCPT ); Tue, 18 Oct 2016 10:30:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42178 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933782AbcJRO3i (ORCPT ); Tue, 18 Oct 2016 10:29:38 -0400 Date: Tue, 18 Oct 2016 10:29:35 -0400 (EDT) Message-Id: <20161018.102935.2077853149914307916.davem@davemloft.net> To: niklas.cassel@axis.com Cc: larper@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, niklass@axis.com, jespern@axis.com Subject: Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported From: David Miller In-Reply-To: <1476775233-14633-1-git-send-email-niklass@axis.com> References: <1476775233-14633-1-git-send-email-niklass@axis.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Oct 2016 07:29:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 18 From: Niklas Cassel Date: Tue, 18 Oct 2016 09:20:33 +0200 > From: Niklas Cassel > > phy_device->supported is originally set by the PHY driver. > The ethernet driver should filter phy_device->supported to only contain > flags supported by the IP. > The IP supports setting rx and tx flow control independently, > therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared. > If the flags are cleared, pause frames cannot be enabled (even if they > are supported by the PHY). > > Signed-off-by: Niklas Cassel > Signed-off-by: Jesper Nilsson > Acked-by: Lars Persson Applied.