Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934388AbcJRObN (ORCPT ); Tue, 18 Oct 2016 10:31:13 -0400 Received: from up.free-electrons.com ([163.172.77.33]:33450 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761804AbcJROaz (ORCPT ); Tue, 18 Oct 2016 10:30:55 -0400 Date: Tue, 18 Oct 2016 16:30:51 +0200 From: Alexandre Belloni To: LABBE Corentin Cc: a.zummo@towertech.it, lars@metafoo.de, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations Message-ID: <20161018143051.3466uyqvw677j3ly@piout.net> References: <1476791753-1837-1-git-send-email-clabbe.montjoie@gmail.com> <20161018141639.owhkvkn4k2rvgspr@piout.net> <20161018142453.GA7552@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161018142453.GA7552@Red> User-Agent: NeoMutt/20160916 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1480 Lines: 48 On 18/10/2016 at 16:24:53 +0200, LABBE Corentin wrote : > On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > > Change since v1: > > > - restored __exit for module_exit function > > > > > > ---8<--- > > > > I don't think this is the proper scissor symbol for git. At least, it is > > no recognized by patchwork and messes your patch. > > > > > From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001 > > > From: Corentin Labbe > > > Date: Mon, 17 Oct 2016 14:17:49 +0200 > > > Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations > > > > > > I got the following stack trace under qemu: > > > > [...] > > > When cmos_set_alarm() is called dev is NULL and so trigger the deref via > > > cmos->irq > > > > > > The problem comes from that the device is removed but no remove function > > > are called due to _exit_p(). > > > > > > This patch remove all _exit_p() annotation. > > > > > > Signed-off-by: Corentin Labbe > > > --- > > > > > > The changelog should go here. > > > > > drivers/rtc/rtc-cmos.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > Sorry, could I just resent it with PATCH RESENT v2 ? or does I need to bump it to v3. > Resending v2 is fine -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com