Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935176AbcJRPFN (ORCPT ); Tue, 18 Oct 2016 11:05:13 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:32832 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935038AbcJRPE6 (ORCPT ); Tue, 18 Oct 2016 11:04:58 -0400 Date: Tue, 18 Oct 2016 11:04:52 -0400 From: Jarod Wilson To: Denis Kirjanov Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking Message-ID: <20161018150452.GU14983@redhat.com> References: <20161017195417.48259-1-jarod@redhat.com> <20161017195417.48259-10-jarod@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1980 Lines: 52 On Tue, Oct 18, 2016 at 04:45:51PM +0300, Denis Kirjanov wrote: > On 10/17/16, Jarod Wilson wrote: > > dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware > > - Removed change_mtu, does nothing productive anymore > > > > sundance: min_mtu 68, max_mtu 8191 > > > > CC: netdev@vger.kernel.org > > CC: Denis Kirjanov > > Signed-off-by: Jarod Wilson > > --- > > drivers/net/ethernet/dlink/dl2k.c | 22 ++++------------------ > > drivers/net/ethernet/dlink/sundance.c | 6 ++++-- > > 2 files changed, 8 insertions(+), 20 deletions(-) ... > > diff --git a/drivers/net/ethernet/dlink/sundance.c > > b/drivers/net/ethernet/dlink/sundance.c > > index 79d8009..eab36ac 100644 > > --- a/drivers/net/ethernet/dlink/sundance.c > > +++ b/drivers/net/ethernet/dlink/sundance.c > > @@ -580,6 +580,10 @@ static int sundance_probe1(struct pci_dev *pdev, > > dev->ethtool_ops = ðtool_ops; > > dev->watchdog_timeo = TX_TIMEOUT; > > > > + /* MTU range: 68 - 8191 */ > > + dev->min_mtu = ETH_MIN_MTU; > > + dev->max_mtu = 8191; > > + > ICPlus datasheet defines the max frame size like 0x1514 or 0x4491 > based on the RcvLargeFrames bit in the MACCtrl0 register I do anticipate this patchset might bring to light some inaccuracies in min/max mtu values currently implemented in various drivers, but for the moment, I'm going for 100% identical behavior with what's currently in the driver, and if you'll look down below... > > pci_set_drvdata(pdev, dev); > > > > i = register_netdev(dev); > > @@ -713,8 +717,6 @@ static int sundance_probe1(struct pci_dev *pdev, > > > > static int change_mtu(struct net_device *dev, int new_mtu) > > { > > - if ((new_mtu < 68) || (new_mtu > 8191)) /* Set by RxDMAFrameLen */ ^^^^ The 8191 was simply transplanted from right here. I think altering the value should be the subject of a separate patch. -- Jarod Wilson jarod@redhat.com