Subject: Re: [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py
To: Peter Griffin <peter.griffin@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@stlinux.com, jan.kiszka@siemens.com
References: <1476803249-23328-1-git-send-email-peter.griffin@linaro.org>
 <1476803249-23328-2-git-send-email-peter.griffin@linaro.org>
Cc: lee.jones@linaro.org, devicetree@vger.kernel.org
From: Kieran Bingham <kieran@ksquared.org.uk>
Message-ID: <477b66cc-05dc-57fa-38fb-f80510935c2e@bingham.xyz>
Date: Tue, 18 Oct 2016 16:27:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1476803249-23328-2-git-send-email-peter.griffin@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 43

Hi Pete,

On 18/10/16 16:07, Peter Griffin wrote:
> proc.py:22:1: E302 expected 2 blank lines, found 1
> proc.py:200:1: E302 expected 2 blank lines, found 1
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  scripts/gdb/linux/proc.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index f20fcfa..2d6f74e 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -18,6 +18,7 @@ from linux import tasks
>  from linux import lists
>  from struct import *
>  
> +

This was added by patch 1, and can be squashed there.

>  class LxCmdLine(gdb.Command):
>      """ Report the Linux Commandline used in the current kernel.
>          Equivalent to cat /proc/cmdline on a running target"""
> @@ -196,6 +197,7 @@ values of that process namespace"""
>  
>  LxMounts()
>  
> +

Likewise...

>  class LxFdtDump(gdb.Command):
>      """Output Flattened Device Tree header and dump FDT blob to a file
>         Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""
> 

-- 
Regards

Kieran Bingham